Gleipnir/jet
4
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

SQL Builder panics on invalid SQL.

Browse source 
Query execution panics on invalid destination.
This commit is contained in:
go-jet 2019-08-13 13:57:26 +02:00
parent 14c2c9d745
commit 486e45db5c
42 changed files with 357 additions and 713 deletions
Download patch file Download diff file Expand all files Collapse all files

6
tests/mysql/alltypes_test.go
View file

@ -234,8 +234,8 @@ func TestFloatOperators(t *testing.T) {
TRUNC(AllTypes.Decimal, Int(1)).AS("trunc"),
).LIMIT(2)
queryStr, _, err := query.Sql()
assert.NilError(t, err)
queryStr, _ := query.Sql()
assert.Equal(t, queryStr, `
SELECT (all_types.numeric = all_types.numeric) AS "eq1",
(all_types.decimal = ?) AS "eq2",
@ -280,7 +280,7 @@ LIMIT ?;
common.FloatExpressionTestResult `alias:"."`
}
err = query.Query(db, &dest)
err := query.Query(db, &dest)
assert.NilError(t, err)

6
tests/postgres/alltypes_test.go
View file

@ -353,8 +353,8 @@ func TestFloatOperators(t *testing.T) {
TRUNC(AllTypes.Decimal, Int(1)).AS("trunc"),
).LIMIT(2)
queryStr, _, err := query.Sql()
assert.NilError(t, err)
queryStr, _ := query.Sql()
assert.Equal(t, queryStr, `
SELECT (all_types.numeric = all_types.numeric) AS "eq1",
(all_types.decimal = $1) AS "eq2",
@ -399,7 +399,7 @@ LIMIT $35;
common.FloatExpressionTestResult `alias:"."`
}
err = query.Query(db, &dest)
err := query.Query(db, &dest)
assert.NilError(t, err)

32
tests/postgres/scan_test.go
View file

@ -18,33 +18,23 @@ var query = Inventory.
func TestScanToInvalidDestination(t *testing.T) {
t.Run("nil dest", func(t *testing.T) {
err := query.Query(db, nil)
assert.Error(t, err, "jet: Destination is nil")
testutils.AssertQueryPanicErr(t, query, db, nil, "jet: destination is nil")
})
t.Run("struct dest", func(t *testing.T) {
err := query.Query(db, struct{}{})
assert.Error(t, err, "jet: Destination has to be a pointer to slice or pointer to struct")
testutils.AssertQueryPanicErr(t, query, db, struct{}{}, "jet: destination has to be a pointer to slice or pointer to struct")
})
t.Run("slice dest", func(t *testing.T) {
err := query.Query(db, []struct{}{})
assert.Error(t, err, "jet: Destination has to be a pointer to slice or pointer to struct")
testutils.AssertQueryPanicErr(t, query, db, []struct{}{}, "jet: destination has to be a pointer to slice or pointer to struct")
})
t.Run("slice of pointers to pointer dest", func(t *testing.T) {
err := query.Query(db, []**struct{}{})
assert.Error(t, err, "jet: Destination has to be a pointer to slice or pointer to struct")
testutils.AssertQueryPanicErr(t, query, db, []**struct{}{}, "jet: destination has to be a pointer to slice or pointer to struct")
})
t.Run("map dest", func(t *testing.T) {
err := query.Query(db, []map[string]string{})
assert.Error(t, err, "jet: Destination has to be a pointer to slice or pointer to struct")
testutils.AssertQueryPanicErr(t, query, db, []map[string]string{}, "jet: destination has to be a pointer to slice or pointer to struct")
})
}
@ -126,9 +116,7 @@ func TestScanToStruct(t *testing.T) {
Inventory **model.Inventory
}{}
err := query.Query(db, &dest)
assert.Error(t, err, "jet: Unsupported dest type: Inventory **model.Inventory")
testutils.AssertQueryPanicErr(t, query, db, &dest, "jet: unsupported dest type: Inventory **model.Inventory")
})
t.Run("invalid dest 2", func(t *testing.T) {
@ -136,9 +124,7 @@ func TestScanToStruct(t *testing.T) {
Inventory ***model.Inventory
}{}
err := query.Query(db, &dest)
assert.Error(t, err, "jet: Unsupported dest type: Inventory ***model.Inventory")
testutils.AssertQueryPanicErr(t, query, db, &dest, "jet: unsupported dest type: Inventory ***model.Inventory")
})
t.Run("custom struct", func(t *testing.T) {
@ -669,9 +655,7 @@ func TestScanToSlice(t *testing.T) {
}
}
err := query.Query(db, &dest)
assert.Error(t, err, "jet: Unsupported dest type: Cities []**struct { *model.City }")
testutils.AssertQueryPanicErr(t, query, db, &dest, "jet: unsupported slice element type at 'Cities []**struct { *model.City }'.")
})
}