diff --git a/clause.go b/clause.go index b0eb7d3..afdf343 100644 --- a/clause.go +++ b/clause.go @@ -130,6 +130,10 @@ func (q *sqlBuilder) writeReturning(statement statementType, returning []project return nil } + if !q.dialect.SupportsReturning { + panic(q.dialect.Name + " dialect does not support RETURNING.") + } + q.newLine() q.writeString("RETURNING") q.increaseIdent() diff --git a/dialects.go b/dialects.go index 5750aa7..9e60cf9 100644 --- a/dialects.go +++ b/dialects.go @@ -20,6 +20,7 @@ func newPostgresDialect() Dialect { postgresDialect.ArgumentPlaceholder = func(ord int) string { return "$" + strconv.Itoa(ord) } + postgresDialect.SupportsReturning = true return postgresDialect } @@ -38,6 +39,8 @@ func newMySQLDialect() Dialect { return "?" } + mySQLDialect.SupportsReturning = false + return mySQLDialect } @@ -49,6 +52,8 @@ type Dialect struct { AliasQuoteChar byte IdentifierQuoteChar byte ArgumentPlaceholder queryPlaceholderFunc + + SupportsReturning bool } func (d *Dialect) serializeOverride(operator string) serializeOverride { diff --git a/mysql/mysql_types.go b/mysql/mysql_types.go index 5c1986d..87b5612 100644 --- a/mysql/mysql_types.go +++ b/mysql/mysql_types.go @@ -94,3 +94,4 @@ var UNION = jet.UNION var STAR = jet.STAR var NULL = jet.NULL +var DEFAULT = jet.DEFAULT diff --git a/tests/init/data/mysql/test_sample.sql b/tests/init/data/mysql/test_sample.sql index 1b24d3d..7883802 100644 --- a/tests/init/data/mysql/test_sample.sql +++ b/tests/init/data/mysql/test_sample.sql @@ -126,3 +126,16 @@ _binary '\0',NULL,'2008-07-04',NULL,'2011-12-18 13:17:17',NULL,'2007-12-31 23:0 +-- Link table -------------------- + +DROP TABLE IF EXISTS test_sample.link; + +CREATE TABLE IF NOT EXISTS test_sample.link ( + id int PRIMARY KEY AUTO_INCREMENT, + url VARCHAR (255) NOT NULL, + name VARCHAR (255) NOT NULL, + description VARCHAR (255) +); + +INSERT INTO test_sample.link (ID, url, name, description) VALUES +(0, 'http://www.youtube.com', 'Youtube' , ''); \ No newline at end of file diff --git a/tests/mysql/insert_test.go b/tests/mysql/insert_test.go new file mode 100644 index 0000000..6183ff5 --- /dev/null +++ b/tests/mysql/insert_test.go @@ -0,0 +1,286 @@ +package mysql + +import ( + "context" + "github.com/go-jet/jet/internal/testutils" + . "github.com/go-jet/jet/mysql" + "github.com/go-jet/jet/tests/.gentestdata/mysql/test_sample/model" + . "github.com/go-jet/jet/tests/.gentestdata/mysql/test_sample/table" + "gotest.tools/assert" + "testing" + "time" +) + +func TestInsertValues(t *testing.T) { + cleanUpLinkTable(t) + + var expectedSQL = ` +INSERT INTO test_sample.link (id, url, name, description) VALUES + (100, 'http://www.postgresqltutorial.com', 'PostgreSQL Tutorial', DEFAULT), + (101, 'http://www.google.com', 'Google', DEFAULT), + (102, 'http://www.yahoo.com', 'Yahoo', NULL); +` + + insertQuery := Link.INSERT(Link.ID, Link.URL, Link.Name, Link.Description). + VALUES(100, "http://www.postgresqltutorial.com", "PostgreSQL Tutorial", DEFAULT). + VALUES(101, "http://www.google.com", "Google", DEFAULT). + VALUES(102, "http://www.yahoo.com", "Yahoo", nil) + + testutils.AssertDebugStatementSql(t, insertQuery, expectedSQL, + 100, "http://www.postgresqltutorial.com", "PostgreSQL Tutorial", + 101, "http://www.google.com", "Google", + 102, "http://www.yahoo.com", "Yahoo", nil) + + _, err := insertQuery.Exec(db) + assert.NilError(t, err) + + insertedLinks := []model.Link{} + + err = Link.SELECT(Link.AllColumns). + WHERE(Link.ID.GT_EQ(Int(100))). + ORDER_BY(Link.ID). + Query(db, &insertedLinks) + + assert.NilError(t, err) + assert.Equal(t, len(insertedLinks), 3) + + assert.DeepEqual(t, insertedLinks[0], postgreTutorial) + + assert.DeepEqual(t, insertedLinks[1], model.Link{ + ID: 101, + URL: "http://www.google.com", + Name: "Google", + }) + + assert.DeepEqual(t, insertedLinks[2], model.Link{ + ID: 102, + URL: "http://www.yahoo.com", + Name: "Yahoo", + }) +} + +var postgreTutorial = model.Link{ + ID: 100, + URL: "http://www.postgresqltutorial.com", + Name: "PostgreSQL Tutorial", +} + +func TestInsertEmptyColumnList(t *testing.T) { + cleanUpLinkTable(t) + + expectedSQL := ` +INSERT INTO test_sample.link VALUES + (100, 'http://www.postgresqltutorial.com', 'PostgreSQL Tutorial', DEFAULT); +` + + stmt := Link.INSERT(). + VALUES(100, "http://www.postgresqltutorial.com", "PostgreSQL Tutorial", DEFAULT) + + testutils.AssertDebugStatementSql(t, stmt, expectedSQL, + 100, "http://www.postgresqltutorial.com", "PostgreSQL Tutorial") + + _, err := stmt.Exec(db) + assert.NilError(t, err) + + insertedLinks := []model.Link{} + + err = Link.SELECT(Link.AllColumns). + WHERE(Link.ID.GT_EQ(Int(100))). + ORDER_BY(Link.ID). + Query(db, &insertedLinks) + + assert.Equal(t, len(insertedLinks), 1) + assert.DeepEqual(t, insertedLinks[0], postgreTutorial) +} + +func TestInsertModelObject(t *testing.T) { + cleanUpLinkTable(t) + var expectedSQL = ` +INSERT INTO test_sample.link (url, name) VALUES + ('http://www.duckduckgo.com', 'Duck Duck go'); +` + + linkData := model.Link{ + URL: "http://www.duckduckgo.com", + Name: "Duck Duck go", + } + + query := Link. + INSERT(Link.URL, Link.Name). + MODEL(linkData) + + testutils.AssertDebugStatementSql(t, query, expectedSQL, "http://www.duckduckgo.com", "Duck Duck go") + + _, err := query.Exec(db) + assert.NilError(t, err) +} + +func TestInsertModelObjectEmptyColumnList(t *testing.T) { + cleanUpLinkTable(t) + var expectedSQL = ` +INSERT INTO test_sample.link VALUES + (1000, 'http://www.duckduckgo.com', 'Duck Duck go', NULL); +` + + linkData := model.Link{ + ID: 1000, + URL: "http://www.duckduckgo.com", + Name: "Duck Duck go", + } + + query := Link. + INSERT(). + MODEL(linkData) + + testutils.AssertDebugStatementSql(t, query, expectedSQL, int32(1000), "http://www.duckduckgo.com", "Duck Duck go", nil) + + _, err := query.Exec(db) + assert.NilError(t, err) +} + +func TestInsertModelsObject(t *testing.T) { + expectedSQL := ` +INSERT INTO test_sample.link (url, name) VALUES + ('http://www.postgresqltutorial.com', 'PostgreSQL Tutorial'), + ('http://www.google.com', 'Google'), + ('http://www.yahoo.com', 'Yahoo'); +` + + tutorial := model.Link{ + URL: "http://www.postgresqltutorial.com", + Name: "PostgreSQL Tutorial", + } + + google := model.Link{ + URL: "http://www.google.com", + Name: "Google", + } + + yahoo := model.Link{ + URL: "http://www.yahoo.com", + Name: "Yahoo", + } + + query := Link. + INSERT(Link.URL, Link.Name). + MODELS([]model.Link{tutorial, google, yahoo}) + + testutils.AssertDebugStatementSql(t, query, expectedSQL, + "http://www.postgresqltutorial.com", "PostgreSQL Tutorial", + "http://www.google.com", "Google", + "http://www.yahoo.com", "Yahoo") + + _, err := query.Exec(db) + assert.NilError(t, err) +} + +func TestInsertUsingMutableColumns(t *testing.T) { + var expectedSQL = ` +INSERT INTO test_sample.link (url, name, description) VALUES + ('http://www.postgresqltutorial.com', 'PostgreSQL Tutorial', DEFAULT), + ('http://www.google.com', 'Google', NULL), + ('http://www.google.com', 'Google', NULL), + ('http://www.yahoo.com', 'Yahoo', NULL); +` + + google := model.Link{ + URL: "http://www.google.com", + Name: "Google", + } + + yahoo := model.Link{ + URL: "http://www.yahoo.com", + Name: "Yahoo", + } + + stmt := Link. + INSERT(Link.MutableColumns). + VALUES("http://www.postgresqltutorial.com", "PostgreSQL Tutorial", DEFAULT). + MODEL(google). + MODELS([]model.Link{google, yahoo}) + + testutils.AssertDebugStatementSql(t, stmt, expectedSQL, + "http://www.postgresqltutorial.com", "PostgreSQL Tutorial", + "http://www.google.com", "Google", nil, + "http://www.google.com", "Google", nil, + "http://www.yahoo.com", "Yahoo", nil) + + _, err := stmt.Exec(db) + assert.NilError(t, err) +} + +func TestInsertQuery(t *testing.T) { + _, err := Link.DELETE(). + WHERE(Link.ID.NOT_EQ(Int(1)).AND(Link.Name.EQ(String("Youtube")))). + Exec(db) + assert.NilError(t, err) + + var expectedSQL = ` +INSERT INTO test_sample.link (url, name) ( + SELECT link.url AS "link.url", + link.name AS "link.name" + FROM test_sample.link + WHERE link.id = 1 +); +` + + query := Link. + INSERT(Link.URL, Link.Name). + QUERY( + SELECT(Link.URL, Link.Name). + FROM(Link). + WHERE(Link.ID.EQ(Int(1))), + ) + + testutils.AssertDebugStatementSql(t, query, expectedSQL, int64(1)) + + _, err = query.Exec(db) + assert.NilError(t, err) + + youtubeLinks := []model.Link{} + err = Link. + SELECT(Link.AllColumns). + WHERE(Link.Name.EQ(String("Youtube"))). + Query(db, &youtubeLinks) + + assert.NilError(t, err) + assert.Equal(t, len(youtubeLinks), 2) +} + +func TestInsertWithQueryContext(t *testing.T) { + cleanUpLinkTable(t) + + stmt := Link.INSERT(). + VALUES(1100, "http://www.postgresqltutorial.com", "PostgreSQL Tutorial", DEFAULT) + + ctx, cancel := context.WithTimeout(context.Background(), 1*time.Microsecond) + defer cancel() + + time.Sleep(10 * time.Millisecond) + + dest := []model.Link{} + err := stmt.QueryContext(ctx, db, &dest) + + assert.Error(t, err, "context deadline exceeded") +} + +func TestInsertWithExecContext(t *testing.T) { + cleanUpLinkTable(t) + + stmt := Link.INSERT(). + VALUES(100, "http://www.postgresqltutorial.com", "PostgreSQL Tutorial", DEFAULT) + + ctx, cancel := context.WithTimeout(context.Background(), 1*time.Microsecond) + defer cancel() + + time.Sleep(10 * time.Millisecond) + + _, err := stmt.ExecContext(ctx, db) + + assert.Error(t, err, "context deadline exceeded") +} + +func cleanUpLinkTable(t *testing.T) { + _, err := Link.DELETE().WHERE(Link.ID.GT(Int(1))).Exec(db) + assert.NilError(t, err) +}