Addressing code review comments

This commit is contained in:
Samir Faci 2024-10-15 08:54:28 -04:00
parent f7082eda68
commit dbd23ed612
3 changed files with 8 additions and 11 deletions

View file

@ -8,7 +8,7 @@ jobs:
build_and_tests: build_and_tests:
docker: docker:
# specify the version # specify the version
- image: cimg/go:1.22.2 - image: cimg/go:1.22.8
- image: cimg/postgres:14.10 - image: cimg/postgres:14.10
environment: environment:
POSTGRES_USER: jet POSTGRES_USER: jet
@ -134,7 +134,7 @@ jobs:
- run: - run:
name: Running tests name: Running tests
command: gotestsum --junitfile report.xml --format testname -- -coverprofile=cover.out -covermode=atomic -coverpkg=github.com/go-jet/jet/v2/postgres/...,github.com/go-jet/jet/v2/mysql/...,github.com/go-jet/jet/v2/sqlite/...,github.com/go-jet/jet/v2/qrm/...,github.com/go-jet/jet/v2/generator/...,github.com/go-jet/jet/v2/internal/... ./... command: gotestsum --junitfile $TEST_RESULTS/report.xml --format testname -- -coverprofile=cover.out -covermode=atomic -coverpkg=github.com/go-jet/jet/v2/postgres/...,github.com/go-jet/jet/v2/mysql/...,github.com/go-jet/jet/v2/sqlite/...,github.com/go-jet/jet/v2/qrm/...,github.com/go-jet/jet/v2/generator/...,github.com/go-jet/jet/v2/internal/... ./...
# run mariaDB and cockroachdb tests. No need to collect coverage, because coverage is already included with mysql and postgres tests # run mariaDB and cockroachdb tests. No need to collect coverage, because coverage is already included with mysql and postgres tests
- run: MY_SQL_SOURCE=MariaDB go test -v ./tests/mysql/ - run: MY_SQL_SOURCE=MariaDB go test -v ./tests/mysql/

View file

@ -7,14 +7,11 @@ on:
branches: branches:
- master - master
env:
GO_VERSION: 1.22.0
permissions: permissions:
contents: read contents: read
# Optional: allow read access to pull request. Use with `only-new-issues` option.
# pull-requests: read env:
go_version: "1.22.8"
jobs: jobs:
@ -25,7 +22,7 @@ jobs:
uses: actions/checkout@v4 uses: actions/checkout@v4
- uses: actions/setup-go@v5 - uses: actions/setup-go@v5
with: with:
go-version: 1.22.0 go-version: ${{ env.go_version }}
cache: true cache: true
- name: Setup Tools - name: Setup Tools
run: | run: |
@ -39,7 +36,7 @@ jobs:
uses: actions/checkout@v4 uses: actions/checkout@v4
- uses: actions/setup-go@v5 - uses: actions/setup-go@v5
with: with:
go-version: 1.22.0 go-version: ${{ env.go_version }}
cache: true cache: true
- name: Setup Tools - name: Setup Tools
run: | run: |

2
go.mod
View file

@ -1,6 +1,6 @@
module github.com/go-jet/jet/v2 module github.com/go-jet/jet/v2
go 1.22.0 go 1.18
require ( require (
github.com/go-sql-driver/mysql v1.8.1 github.com/go-sql-driver/mysql v1.8.1