From 09ae9d0ce3fb556492db06cf90c357c34006644d Mon Sep 17 00:00:00 2001
From: Eli Ribble <eli@gleipnir.technology>
Date: Tue, 24 Mar 2026 09:36:20 -0700
Subject: [PATCH] Move map interfaces to common types for sharing

---
 ts/components/CommunicationColumnDetail.vue | 11 ----
 ts/components/MapMultipoint.vue             | 30 +++------
 ts/components/MapProxiedArcgisTile.vue      | 67 ++++++++++++---------
 ts/components/PlanningColumnDetailEntry.vue | 34 +++--------
 ts/types.ts                                 | 14 +++++
 ts/view/Communication.vue                   | 12 ++--
 ts/view/Planning.vue                        |  1 -
 7 files changed, 77 insertions(+), 92 deletions(-)

diff --git a/ts/components/CommunicationColumnDetail.vue b/ts/components/CommunicationColumnDetail.vue
index fb0bd2b0..d144f5a2 100644
--- a/ts/components/CommunicationColumnDetail.vue
+++ b/ts/components/CommunicationColumnDetail.vue
@@ -27,17 +27,6 @@
 	height: 400px;
 	width: 100%;
 }
-.photo-thumbnail {
-	width: 100px;
-	height: 100px;
-	object-fit: cover;
-	cursor: pointer;
-	border-radius: 4px;
-	transition: transform 0.2s;
-}
-.photo-thumbnail:hover {
-	transform: scale(1.05);
-}
 </style>
 
 <template>
diff --git a/ts/components/MapMultipoint.vue b/ts/components/MapMultipoint.vue
index d8754a26..a24e03d1 100644
--- a/ts/components/MapMultipoint.vue
+++ b/ts/components/MapMultipoint.vue
@@ -1,6 +1,9 @@
 <style scoped>
-@import url("//unpkg.com/maplibre-gl@5.0.1/dist/maplibre-gl.css");
-
+#map {
+	height: 100%;
+	width: 100%;
+	margin-bottom: 10px;
+}
 .map-multipoint {
 	height: 100%;
 	width: 100%;
@@ -17,22 +20,16 @@
 </template>
 
 <script setup lang="ts">
+import "maplibre-gl/dist/maplibre-gl.css";
 import {
 	onMounted,
 	onUnmounted,
 	ref,
 	watch,
 } from "vue";
+import { Bounds, Marker } from "@/types";
 import maplibregl from "maplibre-gl";
 
-interface Point {
-	lat: Number;
-	lng: Number;
-}
-interface Bounds {
-	min: Point;
-	max: Point;
-}
 interface Emits {
 	(e: "load"): void;
 }
@@ -42,13 +39,6 @@ interface Props {
 	"organization-id": int;
 	tegola: string;
 }
-interface Marker {
-	color: string;
-	draggable: boolean;
-	id: string;
-	lng: Number;
-	lat: Number;
-}
 const emit = defineEmits<Emits>();
 const props = withDefaults(defineProps<Props>(), {
 	// default bounds cover a bunch of the continental US
@@ -105,7 +95,7 @@ onMounted(() => {
 		map.value = new maplibregl.Map({
 			bounds: bounds,
 			container: mapContainer.value,
-			//style: "https://tiles.stadiamaps.com/styles/osm_bright.json",
+			style: "https://tiles.stadiamaps.com/styles/osm_bright.json",
 		});
 
 		// Wait for map to load, then add the markers
@@ -166,7 +156,7 @@ function updateMarkers(markers: Marker[]) {
 		if (markerInstances.value.has(markerData.id)) {
 			// Update existing marker position
 			const marker = markerInstances.value.get(markerData.id)!;
-			marker.setLngLat([markerData.lng, markerData.lat]);
+			marker.setLngLat([markerData.location.lng, markerData.location.lat]);
 			console.log("updated", markerData);
 		} else {
 			// Create a new marker
@@ -174,7 +164,7 @@ function updateMarkers(markers: Marker[]) {
 				color: markerData.color,
 				draggable: markerData.draggable,
 			})
-				.setLngLat([markerData.lng, markerData.lat])
+				.setLngLat([markerData.location.lng, markerData.location.lat])
 				.addTo(map.value!);
 
 			markerInstances.value.set(markerData.id, marker);
diff --git a/ts/components/MapProxiedArcgisTile.vue b/ts/components/MapProxiedArcgisTile.vue
index f62b7d01..e5ad7802 100644
--- a/ts/components/MapProxiedArcgisTile.vue
+++ b/ts/components/MapProxiedArcgisTile.vue
@@ -1,40 +1,47 @@
+<style scoped>
+#map {
+	height: 100%;
+	width: 100%;
+	margin-bottom: 10px;
+}
+.map-container {
+	height: 100%;
+	width: 100%;
+}
+</style>
 <template>
-	<div ref="mapContainer" class="map-container"></div>
+	<div v-if="error == null">
+		<div ref="mapContainer" class="map-multipoint"></div>
+	</div>
+	<div v-else>
+		<h1>Map failed to load</h1>
+		<p>{{error}}</p>
+	</div>
 </template>
 
-<script setup>
+<script setup lang="ts">
+import "maplibre-gl/dist/maplibre-gl.css";
 import { ref, watch, onMounted, onBeforeUnmount } from "vue";
 import maplibregl from "maplibre-gl";
-import "maplibre-gl/dist/maplibre-gl.css";
 
-const props = defineProps({
-	latitude: {
-		type: Number,
-		required: true,
-	},
-	longitude: {
-		type: Number,
-		required: true,
-	},
-	organizationId: {
-		type: Number,
-		default: 0,
-	},
-	tegola: {
-		type: String,
-		default: "",
-	},
-	urlTiles: {
-		type: String,
-		default: "",
-	},
-});
+interface Emits {
+	(e: "map-click", latitude: Number, longitude: Number): void
+}
+interface Props {
+	latitude: Number;
+	longitude: Number;
+	organizationId: Number;
+	tegola: string;
+	urlTiles: string;
+}
+const emit = defineEmits<Emits>();
+const props = defineProps<Props>();
 
-const emit = defineEmits(["load", "map-click"]);
-
-const mapContainer = ref(null);
-const map = ref(null);
-const markers = ref([]);
+const error = ref<string | null>(null);
+const mapContainer = ref<HTMLElement | null>(null);
+const map = ref<maplibregl.Map | null>(null);
+const markerInstances = ref<Map<string, maplibrgl.Marker>>(new Map())
+const markers = ref<Map<string, maplibrgl.Marker>>(new Map())
 
 // Watch for latitude/longitude changes
 watch(
diff --git a/ts/components/PlanningColumnDetailEntry.vue b/ts/components/PlanningColumnDetailEntry.vue
index c9ed8351..daaf2445 100644
--- a/ts/components/PlanningColumnDetailEntry.vue
+++ b/ts/components/PlanningColumnDetailEntry.vue
@@ -1,29 +1,10 @@
 <template>
-<!--
-	<td>
-		<button
-			@click="toggleSignal(signal)"
-			class="btn btn-sm btn-link text-danger p-0 ms-1"
-			style="font-size: 0.7rem"
-		>
-			<i class="bi bi-x"></i>
-		</button>
-	</td>
-	<td>
-		<span v-if="signal.type === 'flyover pool'">Pool</span>
-		<span v-else-if="signal.type === 'publicreport nuisance'"
-			>Nuisance</span
-		>
-		<span v-else-if="signal.type === 'publicreport water'"
-			>Water</span
-		>
-	</td>
-	<td>
-		<TimeRelative :time="signal.created"></TimeRelative>
-	</td>
-	<td>{{ shortAddress(signal.address) }}</td>
--->
-	<div v-if="signal.type == 'publicreport nuisance'">
+	<TimeRelative :time="signal.created"></TimeRelative>
+	<p>{{ shortAddress(signal.address) }}</p>
+	<div v-if="signal.type == 'flyover pool'">
+		<FlyoverPoolCard :pool="signal.pool"/>
+	</div>
+	<div v-else-if="signal.type == 'publicreport nuisance'">
 		<PublicreportCard :report="signal.report"/>
 	</div>
 	<div v-else-if="signal.type == 'publicreport water'">
@@ -32,7 +13,8 @@
 </template>
 
 <script setup lang="ts">
-import { shortAddress } from "../format";
+import { shortAddress } from "@/format";
+import FlyoverPoolCard from "@/components/FlyoverPoolCard.vue";
 import PublicreportCard from "@/components/PublicreportCard.vue";
 import TimeRelative from "@/components/TimeRelative.vue";
 interface Props {
diff --git a/ts/types.ts b/ts/types.ts
index e2c7f255..333943b9 100644
--- a/ts/types.ts
+++ b/ts/types.ts
@@ -10,6 +10,20 @@ export interface Communication {
 	public_report: PublicReport | null;
 	type: string;
 }
+export interface Point {
+	lat: Number;
+	lng: Number;
+}
+export interface Bounds {
+	min: Point;
+	max: Point;
+}
+export interface Marker {
+	color: string;
+	draggable: boolean;
+	id: string;
+	location: Point;
+}
 
 export interface PublicReport {
 	created: string;
diff --git a/ts/view/Communication.vue b/ts/view/Communication.vue
index 1a57186a..68bf494b 100644
--- a/ts/view/Communication.vue
+++ b/ts/view/Communication.vue
@@ -268,8 +268,10 @@ function updateMap() {
 			color: "#FF0000",
 			draggable: false,
 			id: String(Date.now()),
-			lng: loc.longitude,
-			lat: loc.latitude,
+			location: {
+				lng: loc.longitude,
+				lat: loc.latitude,
+			}
 		},
 	];
 	console.log("markers now", mapMarkers.value);
@@ -286,8 +288,10 @@ function updateMap() {
 			mapMarkers.value.push({
 				color: "#00FF00",
 				draggable: false,
-				lat: i.location.latitude,
-				lng: i.location.longitude,
+				location: {
+					lat: i.location.latitude,
+					lng: i.location.longitude,
+				},
 			});
 			min.lat = Math.min(min.lat, i.location.latitude);
 			min.lng = Math.min(min.lng, i.location.longitude);
diff --git a/ts/view/Planning.vue b/ts/view/Planning.vue
index 869143e1..621c51c4 100644
--- a/ts/view/Planning.vue
+++ b/ts/view/Planning.vue
@@ -51,7 +51,6 @@
 import { computed, ref, onMounted, nextTick } from "vue";
 
 import MapMultipoint from "../components/MapMultipoint.vue";
-import MapProxiedArcgisTile from "../components/MapProxiedArcgisTile.vue";
 import PlanningColumnAction from "../components/PlanningColumnAction.vue";
 import PlanningColumnDetail from "../components/PlanningColumnDetail.vue";
 import PlanningColumnList from "../components/PlanningColumnList.vue";