lint: remove unused items from resource, sync, platform, db

- Remove contentUploadList/Placeholder/Detail from resource/upload.go
- Remove toImageURLs, userURI from resource/communication.go
- Remove responseListUser from resource/user.go
- Remove contentSignin/getSignin from sync/signin.go (re-add contentSignin used elsewhere)
- Delete sync/service-request.go (entirely unused)
- Remove _rowWithID from platform/signal.go
- Remove unused tag field from db/tx.go Rows struct

resource/communication.go

@@ -6,12 +6,10 @@ import (
 	"strconv"
 	"time"
 
-	"github.com/Gleipnir-Technology/nidus-sync/config"
 	modelpublic "github.com/Gleipnir-Technology/nidus-sync/db/gen/nidus-sync/public/model"
 	modelpublicreport "github.com/Gleipnir-Technology/nidus-sync/db/gen/nidus-sync/publicreport/model"
 	nhttp "github.com/Gleipnir-Technology/nidus-sync/http"
 	"github.com/Gleipnir-Technology/nidus-sync/platform"
-	"github.com/google/uuid"
 	"github.com/gorilla/mux"
 	"github.com/rs/zerolog/log"
 )
@@ -57,17 +55,6 @@ type resourceStub struct {
 	URI     string    `json:"uri"`
 }
 
-func toImageURLs(m map[string][]uuid.UUID, id string) []string {
-	uuids, ok := m[id]
-	if !ok {
-		return []string{}
-	}
-	urls := make([]string, len(uuids))
-	for i, u := range uuids {
-		urls[i] = config.MakeURLNidus("/api/image/%s/content", u.String())
-	}
-	return urls
-}
 func (res *communicationR) Get(ctx context.Context, r *http.Request, user platform.User, query QueryParams) (*communication, *nhttp.ErrorWithStatus) {
 	return nil, nil
 }
@@ -230,9 +217,4 @@ func emailURI(r router, id int32) (string, error) {
 func textURI(r router, id int32) (string, error) {
 	return "fake text uri", nil
 }
-func userURI(r *router, id *int32) (string, error) {
-	if id == nil {
-		return "", nil
-	}
-	return r.IDToURI("user.ByIDGet", int(*id))
-}
+

resource/upload.go

@@ -39,11 +39,6 @@ func (res *uploadR) ByIDGet(ctx context.Context, r *http.Request, u platform.Use
 	return detail, nil
 }
 
-type contentUploadList struct {
-	RecentUploads []platform.Upload
-}
-type contentUploadPlaceholder struct{}
-
 func (res *uploadR) List(ctx context.Context, r *http.Request, user platform.User, req QueryParams) (*contentUploadPoolList, *nhttp.ErrorWithStatus) {
 	rows, err := platform.UploadList(ctx, user.Organization)
 	if err != nil {
@@ -54,11 +49,6 @@ func (res *uploadR) List(ctx context.Context, r *http.Request, user platform.Use
 	}, nil
 }
 
-type contentUploadDetail struct {
-	CSVFileID    int32
-	Organization platform.Organization
-	Upload       platform.Upload
-}
 type contentUploadPoolList struct {
 	Uploads []platform.Upload `json:"uploads"`
 }

resource/user.go

@@ -71,10 +71,6 @@ func (res *userR) response(u *platform.User) (*user, error) {
 type userR struct {
 	router *router
 }
-type responseListUser struct {
-	Users []*platform.User `json:"users"`
-}
-
 func (res *userR) ByIDGet(ctx context.Context, r *http.Request, user platform.User, query QueryParams) (*platform.User, *nhttp.ErrorWithStatus) {
 	vars := mux.Vars(r)
 	user_id_str := vars["id"]