Gleipnir/nidus-sync
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

defer rollback rather than guard returns

Browse source 
I'm trying to make sure we close transactions on the database
This commit is contained in:
Eli Ribble 2026-04-17 18:00:26 +00:00
parent c938cb231e
commit 4a8c0d2e60
No known key found for this signature in database
1 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
platform/start.go
View file

@ -183,27 +183,26 @@ func listenAndDoOneJob(ctx context.Context) error {
}
sublog := log.With().Int32("job", job.ID).Int32("row_id", job.RowID).Str("type", string(job.Type)).Logger()
//tx, err := c.BeginTx(ctx, pgx.TxOptions{})
tx, err := conn.BeginTx(ctx, pgx.TxOptions{})
if err != nil {
return fmt.Errorf("Failed to start transaction: %w", err)
}
defer tx.Rollback(ctx)
ctx, cancel := context.WithCancel(ctx)
txn := bobpgx.NewTx(tx, cancel)
defer txn.Rollback(ctx)
err = handleJob(ctx, txn, job)
if err != nil {
sublog.Error().Err(err).Msg("failed to handle job")
txn.Rollback(ctx)
return nil
}
err = job.Delete(ctx, txn)
if err != nil {
sublog.Error().Err(err).Msg("failed to delete job")
txn.Rollback(ctx)
return fmt.Errorf("delete job: %w", err)
}
txn.Commit(ctx)
//sublog.Debug().Msg("job complete")
sublog.Debug().Msg("job complete")
}
}