Gleipnir/nidus-sync
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

lint: fix errcheck for txn calls, query results, and unchecked errors

Browse source 
- Fix Rollback/Commit in compliance.go, csv/csv.go, csv/pool.go
- Capture and check errors from .One() insert queries in send.go, text.go
- Check errors from markFunc, PopulateURL, and hydrate functions
- Use lint.LogOnErrCtx for best-effort notification sends
This commit is contained in:
Eli Ribble 2026-05-09 02:35:55 +00:00
parent 0ec810591e
commit 679d12b48f
No known key found for this signature in database
10 changed files with 47 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

4
resource/communication.go
View file

@ -194,7 +194,9 @@ func (res *communicationR) markCommunication(ctx context.Context, r *http.Reques
if err != nil {
return communication{}, nhttp.NewBadRequest("can't turn report ID into an int: %w", err)
}
m(ctx, user, int32(comm_id))
if err := m(ctx, user, int32(comm_id)); err != nil {
return communication{}, nhttp.NewError("mark communication: %w", err)
}
result, err := platform.CommunicationFromID(ctx, user, int64(comm_id))
if result == nil {
return communication{}, nhttp.NewUnauthorized("you are not authorized to modify communication %d", comm_id)

12
resource/publicreport_compliance.go
View file

@ -269,10 +269,16 @@ func (res *complianceR) byID(ctx context.Context, r *http.Request, is_public boo
return res.complianceHydrate(report, is_public)
}
func (res *complianceR) complianceHydrate(report *types.PublicReportCompliance, is_public bool) (*types.PublicReportCompliance, *nhttp.ErrorWithStatus) {
populateDistrictURI(&report.PublicReport, res.router)
populateReportURI(&report.PublicReport, res.router, is_public)
if err := populateDistrictURI(&report.PublicReport, res.router); err != nil {
return nil, nhttp.NewError("populate district URI: %w", err)
}
if err := populateReportURI(&report.PublicReport, res.router, is_public); err != nil {
return nil, nhttp.NewError("populate report URI: %w", err)
}
for _, e := range report.Concerns {
e.PopulateURL(res.router.router)
if err := e.PopulateURL(res.router.router); err != nil {
return nil, nhttp.NewError("populate concern URL: %w", err)
}
}
return report, nil
}