From 8730f0034da8dc596ee5641ac7c5572e4c6bca63 Mon Sep 17 00:00:00 2001 From: Eli Ribble Date: Sat, 9 May 2026 02:07:14 +0000 Subject: [PATCH] lint: fix errcheck in api/audio.go and api/district.go renderShim Check the error returned by renderShim and respond with a 500 if rendering fails, consistent with the existing pattern in handleClientIos. --- api/audio.go | 5 ++++- api/district.go | 8 ++++++-- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/api/audio.go b/api/audio.go index 2ed7675f..36153a95 100644 --- a/api/audio.go +++ b/api/audio.go @@ -2,6 +2,7 @@ package api import ( "encoding/json" + "fmt" "io" "net/http" @@ -51,7 +52,9 @@ func apiAudioPost(w http.ResponseWriter, r *http.Request, u platform.User) { UUID: omit.From(noteUUID), } if err := platform.NoteAudioCreate(ctx, u, setter); err != nil { - renderShim(w, r, errRender(err)) + if err := renderShim(w, r, errRender(err)); err != nil { + http.Error(w, fmt.Sprintf("render shim: %v", err), http.StatusInternalServerError) + } return } w.WriteHeader(http.StatusAccepted) diff --git a/api/district.go b/api/district.go index 5386836a..95b938a5 100644 --- a/api/district.go +++ b/api/district.go @@ -16,7 +16,9 @@ func apiGetDistrict(w http.ResponseWriter, r *http.Request) { var latStr, lngStr string err := r.ParseForm() if err != nil { - renderShim(w, r, errRender(fmt.Errorf("Failed to parse GET form: %w", err))) + if err := renderShim(w, r, errRender(fmt.Errorf("Failed to parse GET form: %w", err))); err != nil { + http.Error(w, fmt.Sprintf("render shim: %v", err), http.StatusInternalServerError) + } return } else { latStr = r.FormValue("lat") @@ -24,7 +26,9 @@ func apiGetDistrict(w http.ResponseWriter, r *http.Request) { } lat, err := strconv.ParseFloat(latStr, 64) if err != nil { - renderShim(w, r, errRender(fmt.Errorf("Failed to parse lat as float: %w", err))) + if err := renderShim(w, r, errRender(fmt.Errorf("Failed to parse lat as float: %w", err))); err != nil { + http.Error(w, fmt.Sprintf("render shim: %v", err), http.StatusInternalServerError) + } return } lng, err := strconv.ParseFloat(lngStr, 64)