Gleipnir/nidus-sync
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Stop overwriting the address by ID

Browse source 
We can pull this in the single query we do to the database instead
This commit is contained in:
Eli Ribble 2026-04-13 22:34:36 +00:00
parent 9c557a0391
commit c0389fa4b1
No known key found for this signature in database
1 changed files with 0 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

16
platform/publicreport/report.go
View file

@ -65,17 +65,9 @@ func reportQueryToRows(ctx context.Context, query bob.BaseQuery[*dialect.SelectQ
if err != nil {
return nil, fmt.Errorf("get reports: %w", err)
}
address_ids := make([]int32, 0)
report_ids := make([]int32, len(rows))
for i, row := range rows {
report_ids[i] = row.ID
if row.Address.ID != nil {
address_ids = append(address_ids, *row.Address.ID)
}
}
addresses_by_id, err := loadAddresses(ctx, db.PGInstance.BobDB, address_ids)
if err != nil {
return nil, fmt.Errorf("addresses by ID: %w", err)
}
images_by_id, err := loadImagesForReport(ctx, report_ids)
if err != nil {
@ -88,14 +80,6 @@ func reportQueryToRows(ctx context.Context, query bob.BaseQuery[*dialect.SelectQ
results := make([]*types.PublicReport, len(rows))
for i, row := range rows {
if row.Address.ID != nil {
address, ok := addresses_by_id[*row.Address.ID]
if !ok {
log.Warn().Int32("address.id", *row.Address.ID).Msg("failed to find in addresses_by_id, which means our DB query is wrong")
} else {
row.Address = address
}
}
images, ok := images_by_id[row.ID]
if ok {
row.Images = images