Fix SVG loading for embedded filesystem, add RMO components

This was broken from the template refactor a couple days ago.
This commit is contained in:
Eli Ribble 2026-02-09 21:40:58 +00:00
parent 63193c5324
commit edd9bdcadc
No known key found for this signature in database
2 changed files with 110 additions and 96 deletions

View file

@ -65,7 +65,13 @@ func (ts templateSystemDisk) renderOrError(w http.ResponseWriter, template_name
RespondError(w, "Failed to add supporting templates", err, http.StatusInternalServerError)
return
}
err = ts.addSVGTemplates(t)
svg_fs, err := fs.Sub(ts.sourceFS, "svg")
if err != nil {
log.Error().Err(err).Str("template_name", template_name).Msg("Failed to add get svg subdir")
RespondError(w, "Failed to add supporting svg templates", err, http.StatusInternalServerError)
return
}
err = addSVGTemplates(svg_fs, t)
if err != nil {
log.Error().Err(err).Str("template_name", template_name).Msg("Failed to add supporting templates")
RespondError(w, "Failed to add supporting templates", err, http.StatusInternalServerError)
@ -114,35 +120,6 @@ func (ts templateSystemDisk) addSupportingTemplates(t *template.Template) error
}
return nil
}
func (ts templateSystemDisk) addSVGTemplates(t *template.Template) error {
svg_fs, err := fs.Sub(ts.sourceFS, "svg")
if err != nil {
return fmt.Errorf("Failed to get svg subdir: %w", err)
}
svgs, err := fs.ReadDir(svg_fs, ".")
if err != nil {
log.Warn().Msg("Failed to read svg directory")
return nil
}
for _, svg := range svgs {
content, err := fs.ReadFile(svg_fs, svg.Name())
if err != nil {
return fmt.Errorf("Failed to read svg '%s' from embedded filesystem: %w", svg, err)
}
svg_name := svg.Name()
svg_template := fmt.Sprintf("{{define \"%s\"}}%s{{end}}", svg_name, string(content))
svg_t, err := template.New(svg_name).Parse(svg_template)
if err != nil {
return fmt.Errorf("Failed to parse svg '%s' from embedded filesystem: %v", svg, err)
}
_, err = t.AddParseTree(svg_t.Name(), svg_t.Tree)
if err != nil {
return fmt.Errorf("Failed to add svg '%s' to embedded template: %v", svg, err)
}
//log.Debug().Str("name", svg_name).Msg("add svg template")
}
return nil
}
func (ts templateSystemDisk) parseTemplate(filename string) (*template.Template, error) {
t := template.New(filename)
log.Debug().Str("filename", filename).Msg("parsing template")
@ -157,14 +134,101 @@ func (ts templateSystemDisk) parseTemplate(filename string) (*template.Template,
}
return t, nil
}
func addSVGTemplates(fsys fs.FS, templ *template.Template) error {
svgs, err := fs.ReadDir(fsys, ".")
/*
func addSVGTemplates(fsys fs.FS, templ *template.Template) error {
svgs, err := fs.ReadDir(fsys, ".")
if err != nil {
log.Warn().Msg("Failed to read svg directory")
return nil
}
for _, svg := range svgs {
content, err := fs.ReadFile(fsys, svg.Name())
if err != nil {
return fmt.Errorf("Failed to read svg '%s' from embedded filesystem: %w", svg, err)
}
svg_name := svg.Name()
svg_template := fmt.Sprintf("{{define \"%s\"}}%s{{end}}", svg_name, string(content))
svg_t, err := template.New(svg_name).Parse(svg_template)
if err != nil {
return fmt.Errorf("Failed to parse svg '%s' from embedded filesystem: %v", svg, err)
}
_, err = templ.AddParseTree(svg_t.Name(), svg_t.Tree)
if err != nil {
return fmt.Errorf("Failed to add svg '%s' to embedded template: %v", svg, err)
}
//log.Debug().Str("name", svg_name).Msg("add svg template")
}
return nil
}
func executeTemplate(w io.Writer, data any) error {
if bt.template == nil {
name := path.Base(bt.files[0])
templ, err := parseFromDisk(bt.subdir, bt.files)
if err != nil {
return fmt.Errorf("Failed to parse template file: %w", err)
}
if templ == nil {
w.Write([]byte("Failed to read from disk: "))
return errors.New("Template parsing failed")
}
//log.Debug().Str("name", templ.Name()).Msg("Parsed template")
return templ.ExecuteTemplate(w, name, data)
} else {
name := path.Base(bt.files[0])
return bt.template.ExecuteTemplate(w, name, data)
}
}
func parseEmbedded(embeddedFiles embed.FS, subdir string, files []string) *template.Template {
funcMap := makeFuncMap()
// Remap the file names to embedded paths
embeddedFilePaths := make([]string, 0)
for _, f := range files {
embeddedFilePaths = append(embeddedFilePaths, strings.TrimPrefix(f, subdir))
}
name := path.Base(embeddedFilePaths[0])
log.Debug().Str("name", name).Strs("paths", embeddedFilePaths).Msg("Parsing embedded template")
t, err := template.New(name).Funcs(funcMap).ParseFS(embeddedFiles, embeddedFilePaths...)
if err != nil {
panic(fmt.Sprintf("Failed to parse embedded template %s: %v", name, err))
}
svg_fs, err := fs.Sub(embeddedFiles, "template/svg")
if err != nil {
panic(fmt.Sprintf("Failed to read static/svg: %v", err))
}
err = addSVGTemplates(svg_fs, t)
if err != nil {
panic(fmt.Sprintf("Failed to add SVG templates: %v", err))
}
return t
}
func parseFromDisk(subdir string, files []string) (*template.Template, error) {
funcMap := makeFuncMap()
name := path.Base(files[0])
//log.Debug().Str("name", name).Strs("files", files).Msg("parsing from disk")
templ, err := template.New(name).Funcs(funcMap).ParseFiles(files...)
if err != nil {
return nil, fmt.Errorf("Failed to parse %s: %w", files, err)
}
fsys := os.DirFS(subdir + "/template/svg")
err = addSVGTemplates(fsys, templ)
if err != nil {
return nil, fmt.Errorf("Failed to add SVGs from disk: %w", err)
}
return templ, nil
}
*/
func addSVGTemplates(filesystem fs.FS, t *template.Template) error {
svgs, err := fs.ReadDir(filesystem, ".")
if err != nil {
log.Warn().Msg("Failed to read svg directory")
return nil
}
for _, svg := range svgs {
content, err := fs.ReadFile(fsys, svg.Name())
content, err := fs.ReadFile(filesystem, svg.Name())
if err != nil {
return fmt.Errorf("Failed to read svg '%s' from embedded filesystem: %w", svg, err)
}
@ -174,70 +238,12 @@ func addSVGTemplates(fsys fs.FS, templ *template.Template) error {
if err != nil {
return fmt.Errorf("Failed to parse svg '%s' from embedded filesystem: %v", svg, err)
}
_, err = templ.AddParseTree(svg_t.Name(), svg_t.Tree)
_, err = t.AddParseTree(svg_t.Name(), svg_t.Tree)
if err != nil {
return fmt.Errorf("Failed to add svg '%s' to embedded template: %v", svg, err)
}
//log.Debug().Str("name", svg_name).Msg("add svg template")
log.Debug().Str("name", svg_name).Msg("add svg template")
}
log.Debug().Msg("Done adding SVG templates")
return nil
}
/*
func executeTemplate(w io.Writer, data any) error {
if bt.template == nil {
name := path.Base(bt.files[0])
templ, err := parseFromDisk(bt.subdir, bt.files)
if err != nil {
return fmt.Errorf("Failed to parse template file: %w", err)
}
if templ == nil {
w.Write([]byte("Failed to read from disk: "))
return errors.New("Template parsing failed")
}
//log.Debug().Str("name", templ.Name()).Msg("Parsed template")
return templ.ExecuteTemplate(w, name, data)
} else {
name := path.Base(bt.files[0])
return bt.template.ExecuteTemplate(w, name, data)
}
}
func parseEmbedded(embeddedFiles embed.FS, subdir string, files []string) *template.Template {
funcMap := makeFuncMap()
// Remap the file names to embedded paths
embeddedFilePaths := make([]string, 0)
for _, f := range files {
embeddedFilePaths = append(embeddedFilePaths, strings.TrimPrefix(f, subdir))
}
name := path.Base(embeddedFilePaths[0])
log.Debug().Str("name", name).Strs("paths", embeddedFilePaths).Msg("Parsing embedded template")
t, err := template.New(name).Funcs(funcMap).ParseFS(embeddedFiles, embeddedFilePaths...)
if err != nil {
panic(fmt.Sprintf("Failed to parse embedded template %s: %v", name, err))
}
svg_fs, err := fs.Sub(embeddedFiles, "template/svg")
if err != nil {
panic(fmt.Sprintf("Failed to read static/svg: %v", err))
}
err = addSVGTemplates(svg_fs, t)
if err != nil {
panic(fmt.Sprintf("Failed to add SVG templates: %v", err))
}
return t
}
func parseFromDisk(subdir string, files []string) (*template.Template, error) {
funcMap := makeFuncMap()
name := path.Base(files[0])
//log.Debug().Str("name", name).Strs("files", files).Msg("parsing from disk")
templ, err := template.New(name).Funcs(funcMap).ParseFiles(files...)
if err != nil {
return nil, fmt.Errorf("Failed to parse %s: %w", files, err)
}
fsys := os.DirFS(subdir + "/template/svg")
err = addSVGTemplates(fsys, templ)
if err != nil {
return nil, fmt.Errorf("Failed to add SVGs from disk: %w", err)
}
return templ, nil
}
*/