Tell the user when they don't give us an address

Issue: #25

platform/publicreport.go

@@ -29,6 +29,8 @@ import (
 	"source.gleipnir.technology/Gleipnir/nidus-sync/platform/types"
 )
 
+var ErrNoAddress = errors.New("no-address")
+
 // GenerateReportID creates a 12-character random string using only unambiguous
 // capital letters and numbers
 func GenerateReportID() (string, error) {
@@ -366,7 +368,7 @@ func publicReportCreate(ctx context.Context, setter_report modelpublicreport.Rep
 			}
 			addr = &geo_res.Address
 		} else {
-			return result, fmt.Errorf("empty address")
+			return result, ErrNoAddress
 		}
 	}
 

resource/publicreport_nuisance.go

@@ -2,6 +2,7 @@ package resource
 
 import (
 	"context"
+	"errors"
 	"net/http"
 	"slices"
 	"time"
@@ -125,6 +126,9 @@ func (res *nuisanceR) Create(ctx context.Context, r *http.Request, n nuisanceFor
 	}
 	report, err := platform.PublicReportNuisanceCreate(ctx, setter_report, setter_nuisance, n.Location, n.Address, uploads)
 	if err != nil {
+		if errors.Is(err, platform.ErrNoAddress) {
+			return nil, nhttp.NewBadRequest("empty-address")
+		}
 		return nil, nhttp.NewError("create nuisance report: %w", err)
 	}
 	uri, err := res.router.IDStrToURI("publicreport.ByIDGetPublic", report.PublicID)

ts/rmo/components/ErrorNotification.vue

@@ -1,80 +1,80 @@
 <style scoped>
 .error-notification {
-    background-color: #f8d7da;
+	background-color: #f8d7da;
-    border: 1px solid #f5c6cb;
+	border: 1px solid #f5c6cb;
-    border-radius: 0.375rem;
+	border-radius: 0.375rem;
-    padding: 1rem 1.25rem;
+	padding: 1rem 1.25rem;
-    margin-bottom: 1rem;
+	margin-bottom: 1rem;
-    display: flex;
+	display: flex;
-    align-items: center;
+	align-items: center;
-    gap: 0.75rem;
+	gap: 0.75rem;
 }
 .error-icon {
-    font-size: 1.25rem;
+	font-size: 1.25rem;
-    flex-shrink: 0;
+	flex-shrink: 0;
 }
 .error-text {
-    color: #721c24;
+	color: #721c24;
-    flex: 1;
+	flex: 1;
 }
 .error-dismiss {
-    background: none;
+	background: none;
-    border: none;
+	border: none;
-    color: #721c24;
+	color: #721c24;
-    font-size: 1.25rem;
+	font-size: 1.25rem;
-    cursor: pointer;
+	cursor: pointer;
-    padding: 0 0.25rem;
+	padding: 0 0.25rem;
-    line-height: 1;
+	line-height: 1;
-    opacity: 0.7;
+	opacity: 0.7;
 }
 .error-dismiss:hover {
-    opacity: 1;
+	opacity: 1;
 }
 </style>
 
 <template>
-    <div v-if="visible" class="error-notification" role="alert">
+	<div v-if="visible" class="error-notification" role="alert">
-        <span class="error-icon" aria-hidden="true">✗</span>
+		<span class="error-text">{{ message }}</span>
-        <span class="error-text">{{ message }}</span>
+		<button
-        <button
+			v-if="dismissible"
-            v-if="dismissible"
+			type="button"
-            type="button"
+			class="error-dismiss"
-            class="error-dismiss"
+			aria-label="Dismiss error"
-            aria-label="Dismiss error"
+			@click="dismiss"
-            @click="dismiss"
+		>
-        >
+			×
-            ×
+		</button>
-        </button>
+	</div>
-    </div>
 </template>
 
 <script setup lang="ts">
 import { ref } from "vue";
 
 const props = withDefaults(
-    defineProps<{
+	defineProps<{
-        message?: string;
+		message?: string;
-        dismissible?: boolean;
+		dismissible?: boolean;
-    }>(),
+	}>(),
-    {
+	{
-        message: "Something went wrong. Your request could not be completed. Please try again.",
+		message:
-        dismissible: true,
+			"Something went wrong. Your request could not be completed. Please try again.",
-    },
+		dismissible: true,
+	},
 );
 
 const emit = defineEmits<{
-    dismissed: [];
+	dismissed: [];
 }>();
 
 const visible = ref(true);
 
 function dismiss() {
-    visible.value = false;
+	visible.value = false;
-    emit("dismissed");
+	emit("dismissed");
 }
 
 function show() {
-    visible.value = true;
+	visible.value = true;
 }
 
 defineExpose({ show, dismiss });

ts/rmo/content/Nuisance.vue

@@ -477,6 +477,7 @@ import { useStoreLocal } from "@/store/local";
 import { useStorePublicReport } from "@/store/publicreport";
 import type { Marker } from "@/types";
 import {
+	type APIError,
 	type Geocode,
 	type GeocodeSuggestion,
 	type PublicReport,
@@ -535,7 +536,16 @@ async function doSubmit() {
 			// Don't set Content-Type, the browser should do it
 		});
 		if (!resp.ok) {
-			errorMessage.value = "Something went wrong. Your request could not be completed. Please try again.";
+			if (resp.status == 400) {
+				const data: APIError = (await resp.json()) as APIError;
+				if (data.message == "empty-address") {
+					errorMessage.value =
+						"You must provide either an address, or a location on the map, otherwise we don't have much to work with.";
+				}
+			} else {
+				errorMessage.value =
+					"Something went wrong. Your request could not be completed. Please try again.";
+			}
 			return;
 		}
 		const data: PublicReport = (await resp.json()) as PublicReport;

ts/type/api.ts

@@ -31,6 +31,9 @@ export class Address {
 		public location?: Location,
 	) {}
 }
+export interface APIError {
+	message: string;
+}
 export interface TegolaURLs {
 	nidus: string;
 	rmo: string;