fix: guard publicReportUpdateAddressID against empty GID+Raw #151

Merged

eliribble merged 1 commit from issue-149-publicreport-address-guard into main

2026-07-20 17:27:04 +00:00

ned commented

2026-07-20 17:04:08 +00:00

Member

SELECT id FROM public.address WHERE gid = '' LIMIT 1

On organization 1 this matches address 68 (the first address inserted with gid = ''), which was likely created during early development/MVCAC demos. The result: every report submitted through the door-hanger (district) path with an incomplete address gets attached to this same address, causing the unrelated-reports issue Alysia reported.

Fix: Add an early return guard at the top of publicReportUpdateAddressID when both GID and Raw are empty. No address data to set, so leave the report's address_id unchanged.

See issue #149 comment for the full root-cause analysis.

When the frontend submits an address update with both GID and Raw empty (e.g., user clicked the map and continued before the async reverse geocode completed, or the reverse geocode failed), the else branch in `publicReportUpdateAddressID` falls through to: ```sql SELECT id FROM public.address WHERE gid = '' LIMIT 1 ``` On organization 1 this matches address 68 (the first address inserted with `gid = ''`), which was likely created during early development/MVCAC demos. The result: every report submitted through the door-hanger (district) path with an incomplete address gets attached to this same address, causing the unrelated-reports issue Alysia reported. **Fix:** Add an early return guard at the top of `publicReportUpdateAddressID` when both GID and Raw are empty. No address data to set, so leave the report's address_id unchanged. See issue #149 comment for the full root-cause analysis.

ned added 1 commit

2026-07-20 17:04:08 +00:00

fix: guard publicReportUpdateAddressID against empty GID+Raw

/ golint (push) Successful in 12s

Details

/ pnpm-build (push) Successful in 32s

Details

479496e326

When both GID and Raw are empty, the else branch executes
`WHERE address.gid = '' LIMIT 1`, which picks whatever address was
first inserted with an empty GID column. On organization 1 this happens
to be address 68, resulting in dozens of unrelated reports all being
attached to it.

Adding an early return guard prevents this fallthrough and ensures that
submitting an address with no data leaves the report's address_id
unchanged.

ned referenced this pull request

2026-07-20 17:04:16 +00:00

Multiple reports attached to communication #149