fix: check H3Cell error and use proper string value in publicReportUpdateLocation #161

Merged

eliribble merged 1 commit from issue-160-h3cell-bad-data into main

2026-07-23 04:40:43 +00:00

ned commented

2026-07-23 04:37:57 +00:00

Member

Fixes issue #160.

Two bugs in publicReportUpdateLocation:

Discarded error: location.H3Cell() returned (cell, error) but the error was silently discarded with _. When invalid coordinates produced a zero-value cell (H3_NULL / Cell 0), the error was lost and the bad data was stored.
Wrong value type: The H3cell column is a postgres.ColumnString, but the SET clause used postgres.Int(int64(*h3cell)). For valid cells this happened to work because PostgreSQL casts integer literals to h3index, but for cell 0 it stored 0 — an invalid h3index string that crashes on read via H3Index.Scan().

Fix: Check the H3Cell error and return it wrapped. Use postgres.String(h3cell.String()) to pass the proper hex string representation.

Fixes issue #160. Two bugs in `publicReportUpdateLocation`: 1. **Discarded error:** `location.H3Cell()` returned `(cell, error)` but the error was silently discarded with `_`. When invalid coordinates produced a zero-value cell (H3_NULL / Cell 0), the error was lost and the bad data was stored. 2. **Wrong value type:** The `H3cell` column is a `postgres.ColumnString`, but the SET clause used `postgres.Int(int64(*h3cell))`. For valid cells this happened to work because PostgreSQL casts integer literals to h3index, but for cell 0 it stored `0` — an invalid h3index string that crashes on read via `H3Index.Scan()`. **Fix:** Check the H3Cell error and return it wrapped. Use `postgres.String(h3cell.String())` to pass the proper hex string representation.

ned added 1 commit

2026-07-23 04:37:57 +00:00

fix: check H3Cell error and use proper string value in publicReportUpdateLocation

/ golint (push) Successful in 19s

Details

/ pnpm-build (push) Failing after 3s

Details

f27a40391b

Two bugs in publicReportUpdateLocation:
1. The error from location.H3Cell() was silently discarded with _,
   allowing invalid coordinates to pass through and store a zero H3
   cell (Cell 0 / H3_NULL) in the database.
2. The H3cell column is a postgres.ColumnString, but the SET was
   using postgres.Int(int64(*h3cell)). For valid cells this happened
   to work because PostgreSQL casts integer literals to h3index, but
   for cell 0 it stored '0' — an invalid h3index that fails on read.

Fix: check the error from H3Cell() and return it wrapped, and use
postgres.String(h3cell.String()) to pass the proper hex string
representation that the h3index type expects.

ned referenced this pull request

2026-07-23 04:38:05 +00:00

500-level error on /api/communication #160