Commit graph

1675 commits

Author SHA1 Message Date
7270de2937 lint: fix remaining errcheck issues across multiple files
- Fix renderShim errcheck in district.go, image.go
- Fix txn.Rollback/Commit in publicreport.go, notification, review, signal, upload
- Fix addError calls in csv/flyover.go, csv/pool.go
- Fix cW/write calls in logger.go, recoverer.go, voipms.go
- Fix resendInitialText, handleWaitingTextJobs, setPhoneStatus in text/send.go, text.go
- Fix populateDistrictURI/populateReportURI in resource files
2026-05-09 03:06:56 +00:00
808e172221
lint: fix remaining errcheck for Write, Fprintf, Rollback, Commit
- Use lint.Write for unchecked w.Write in handlerJSONPost/Put, report
- Use lint.Fprintf for fmt.Fprintf in twilio handlers
- Use lint.LogOnErrRollback for deferred Rollbacks in compliance, lead, note
- Check errors from txn.Commit in lead, note
- Use lint.LogOnErrCtx for addError calls in flyover
2026-05-09 02:41:49 +00:00
679d12b48f
lint: fix errcheck for txn calls, query results, and unchecked errors
- Fix Rollback/Commit in compliance.go, csv/csv.go, csv/pool.go
- Capture and check errors from .One() insert queries in send.go, text.go
- Check errors from markFunc, PopulateURL, and hydrate functions
- Use lint.LogOnErrCtx for best-effort notification sends
2026-05-09 02:35:55 +00:00
0ec810591e
lint: fix errcheck for Close and Write calls across multiple files
Use lint.LogOnErr for deferred Body/File/Client Close calls.
Use lint.Write for unchecked w.Write calls.
Fix bug in sync/sms.go where fmt.Errorf result was discarded
(replace with proper log.Error call).
2026-05-09 02:29:07 +00:00
c7a7e8431c
lint: fix errcheck for fmt.Fprintf/Fprint across multiple files
Add lint.Fprint helper for unchecked fmt.Fprint calls.
Use lint.Fprintf/Fprint in api/event.go, api/image.go, rmo/root.go.
Add explicit error check for fmt.Fprintf in middleware/terminal.go cW.
2026-05-09 02:21:53 +00:00
934fb03ca2
lint: fix errcheck for txn.Rollback/Commit and insert in platform
Use lint.LogOnErrRollback for deferred Rollbacks in arcgis.go.
Capture and check errors from txn.Commit and CommunicationLogEntryInsert.
2026-05-09 02:17:25 +00:00
4008b9aa25
lint: fix errcheck for txn.Rollback/Commit and r.Close
Use lint.LogOnErrRollback for deferred Rollback in test-jet.
Use lint.LogOnErrCtx for Commit in test-jet.
Use lint.LogOnErr for r.Close in ExecuteNoneTxBob.
2026-05-09 02:14:47 +00:00
8993a6dcb7
lint: fix errcheck in api/handler.go w.Write calls
Replace unchecked w.Write(body) with lint.Write(w, body) in handlerJSON,
handlerJSONSlice, and handlerFormUpload.
2026-05-09 02:08:15 +00:00
8730f0034d
lint: fix errcheck in api/audio.go and api/district.go renderShim
Check the error returned by renderShim and respond with a 500 if
rendering fails, consistent with the existing pattern in handleClientIos.
2026-05-09 02:07:14 +00:00
c83606908f
lint: fix errcheck in api/api.go debug log writes
Add lint.Fprintf and lint.Write helpers for safe writer operations.
Use lint.Fprintf for unchecked fmt.Fprintf calls in webhookFieldseeker.
2026-05-09 02:05:40 +00:00
970cd568dc
Add generated jet tables and models
These will change with schema changes
2026-05-09 01:54:12 +00:00
935800e334
Switch to using the Gleipnir fork of jet
Because we need those sweet, sweet geometry columns
2026-05-09 01:48:56 +00:00
b5bc54b7f4
Start adding context resources to communications
These will contain URIs for anything related to the communication
2026-05-09 01:39:08 +00:00
0301545df9
Go back to replacing jet for now
I need it for my geometry column types
2026-05-09 01:38:36 +00:00
e36b512908
Stop ignoring any paths with 'nidus-sync' in them
Dumb oversight on my part
2026-05-09 01:38:07 +00:00
aa3c6e6209
Don't use custom jet, tidy module 2026-05-09 01:22:30 +00:00
93b69c4cbb
Remove dead query.go at project root
The QueryWriter interface and queryToString function had zero callers.
The commented-out insertQueryToString was a Bob remnant. The io import
was only used in this file.
2026-05-09 01:05:29 +00:00
7ffa2e891b
Remove dead esbuild build.js and flake.nix dependency
build.js was an esbuild-based build script from the pre-Vite era (March 2026).
It is not referenced by package.json, CI, or any config. Vite is used for
both sync and rmo builds. Also dropped pkgs.esbuild from flake.nix devShell.
2026-05-09 01:03:51 +00:00
be99baf64c
Remove unused tomtom/ integration
TomTom was added Feb 2026 for routing but was never imported outside
its own directory. Stadia Maps is now the geocoding and tile provider.
No references in go.mod, go.sum, or any Go file.
2026-05-09 01:01:49 +00:00
8592659432
Test of agent capabilities:
"I'd like you to take a look at the project nidus-sync. It has been developed over the past 6 months and had several different architectural approaches that have evolved over time. The git history may be especially useful to see the
evolution. Write up a report of what you understand has happend, with approximate timelines. This should go in HISTORY.md. Determine which changes are incomplete - libraries or approaches that are no longer preferred, but not fully
removed yet. Create another file, CLEANUP.md, which lists out cleanup
efforts that should be done to completely remove these older,
less-preferred parts of the code."
2026-05-09 00:54:39 +00:00
1b6fac3313
Distinguish between communication stubs and full resources
This is useful so I don't have to pull together the entirety of the log
for a communication list, which would be much more expensive.
2026-05-09 00:03:11 +00:00
01f35b603e
Add centralized error handler for sync Vue app 2026-05-08 23:33:49 +00:00
da90401b2d
Push location config to client
We'll let the default stay the default.
2026-05-08 22:48:51 +00:00
28cf7683a7
Pass-through an address shim with whatever data we have 2026-05-08 22:45:26 +00:00
d1ba2f53fa
Fix setting address on compliance reports
This error was subtle. First, we want to set the GID and raw content
directly using the updater instead of doing two round trips because we
can. Second, we want to do some geocoding if the address isn't already
in the system. Likely it is, because the frontend would have requested a
geocode, but it's possible that it isn't.
2026-05-08 22:43:57 +00:00
24a3610c4c
Correctly build updaters with New
Otherwise we have nil columns
2026-05-08 22:22:52 +00:00
7da653efc6
Avoid a DB query if there are no address IDs 2026-05-08 22:21:56 +00:00
735a9dc1d2
Properly close rows on empty results
I we don't do this we get "conn busy" errors.
2026-05-08 22:21:27 +00:00
f2585c569c
Woops, actually set all columns on compliance because it doesn't have a serial key 2026-05-08 01:08:06 +00:00
0fc46d5916
Only set mutable columns on insert
Because we don't want to set ID and other primary keys
2026-05-08 00:56:55 +00:00
61ad3fbe45
Remove string-based queries for public report data
Use the new jet hotness
2026-05-07 23:22:50 +00:00
12213fb31b
Remove string-only references to location_* generated columns 2026-05-07 17:01:54 +00:00
7a361a330d
Remove now-extraneous latitude/longitude generated columns
Now that we can pull out the geometry directly into a go object we don't
need these and they complicate our insertions
2026-05-07 16:38:42 +00:00
34a136eba5
Move user to compliance complete page for submitted reports 2026-05-07 16:17:00 +00:00
fcd95f1a25
Get back to compiling, but using new jet for publicreport
This was an epically long change, and a terrible idea, but it compiles.
This was essentially a cascade that came about because I can't blend jet
and bob in the same transaction. In for a penny, I guess...
2026-05-07 10:39:17 +00:00
a95e44cf42
Use transactions to set the communication status changes
Not doing it yet, but soon we'll do log entries for them.
2026-05-04 20:57:50 +00:00
040ab106b4
Fix failing to set timestamp in mark query
I accidentally didn't understand how this API works.
2026-05-04 20:30:36 +00:00
5f3fcc2b3e
Fix a bunch of not-checking-error lints 2026-05-04 20:29:02 +00:00
114aec73ed
Fix setting timestamp for when action is taken 2026-05-04 20:09:56 +00:00
60bf09e813
Avoid emitting error on transaction rollback that's complete
It's on purpose
2026-05-04 19:53:36 +00:00
347f62bd6d
Fix method on marking communications 2026-05-04 19:43:37 +00:00
878f0e9bcf
Try a different way to limit linting 2026-05-04 19:43:20 +00:00
18db17fe0b
Don't lint every go file on every commit.
Faster commits, less redundancy
2026-05-04 19:40:12 +00:00
b53c908b55
Fix warning from sentry setup 2026-05-04 19:39:17 +00:00
dc2fee3a9d
Fix selecting items in the communication list 2026-05-04 19:39:03 +00:00
387be40076
Return ID as a string from API
Because they are opaque, not something to math
2026-05-04 19:37:05 +00:00
3153e8bf13
Initial work marking communications
And a bunch of lint fixes
2026-05-04 19:07:29 +00:00
67c99436d1
Properly set submitted on PUT, return new status properties on comms 2026-05-02 00:41:31 +00:00
431435f8bd
Set the organization on inserted communications 2026-05-02 00:38:38 +00:00
57dc2023cd
Remove unused submit function 2026-05-02 00:38:12 +00:00