fix: ensure destination DID is in phone table before text_log insert #107

Closed

ned wants to merge 0 commits from fix/incoming-text-missing-destination-phone into main

ned commented

2026-07-13 19:44:33 +00:00

Member

Root cause: When an incoming SMS/MMS arrives via the VoIP.ms webhook, HandleTextMessage calls ensurePhoneInDB for the source (customer's number from VoIP.ms from field) but not for the destination (our DID from VoIP.ms to field). The text_log.destination column has a FK constraint text_log_destination_fkey → phone(e164), so the insert fails with SQLSTATE 23503 when the DID hasn't been pre-registered.

Fix: Add ensurePhoneInDB for the destination number before the text_log insert, matching the pattern already used for the source.

Closes #106

**Root cause:** When an incoming SMS/MMS arrives via the VoIP.ms webhook, `HandleTextMessage` calls `ensurePhoneInDB` for the *source* (customer's number from VoIP.ms `from` field) but not for the *destination* (our DID from VoIP.ms `to` field). The `text_log.destination` column has a FK constraint `text_log_destination_fkey → phone(e164)`, so the insert fails with SQLSTATE 23503 when the DID hasn't been pre-registered. **Fix:** Add `ensurePhoneInDB` for the destination number before the `text_log` insert, matching the pattern already used for the source. Closes #106

ned added 1 commit

2026-07-13 19:44:33 +00:00

fix: ensure destination DID is registered in phone table before inserting text_log

/ golint (push) Successful in 1m1s

Details

/ pnpm-build (push) Successful in 27s

Details

f232664cd2

When an incoming SMS/MMS arrives via the VoIP.ms webhook,
HandleTextMessage only calls ensurePhoneInDB for the source
(the customer's number), but not for the destination (our DID).
The text_log.destination column has a foreign key constraint
referencing phone(e164), so the insert fails with a 23503 error
when the DID has not been pre-registered.

The fix adds an ensurePhoneInDB call for the destination before
the text_log insert, using PhoneInsertIfNotExists which is safe
to call even when the number already exists.

ned added 1 commit

2026-07-13 20:06:35 +00:00

fix: ensure source and destination are in phone table for all outbound texts

/ golint (push) Successful in 56s

Details

/ pnpm-build (push) Successful in 27s

Details

3211570912

The sendTextDirect function is the common path for every outgoing text
(command responses, initial texts, district messages via job
completion).  It uses config.PhoneNumberReportStr as the text_log.source
field, but never verifies that number exists in the phone table before
inserting.  The text_log.source column has a foreign key constraint
referencing phone(e164), so the insert fails with a 23503 error when
the outbound number hasn't been pre-registered.

The HandleTextMessage path (incoming texts) handles this correctly with
explicit ensurePhoneInDB calls, but respondText / sendTextCommandResponse
go through sendTextDirect, which skips the check.

The fix adds ensurePhoneInDB for both source and destination inside
sendTextDirect, so every outbound text path is covered regardless of
how the function is called.

ned referenced this pull request

2026-07-13 20:06:52 +00:00

Incoming text MMS image failure #106