Gleipnir/nidus-sync
4
0
Fork 0
Code Issues 20 Pull requests Projects Releases Packages Wiki Activity Actions

POI address input bug #14

New issue
Closed
opened 2026-05-21 17:09:47 +00:00 by eliribble · 7 comments
eliribble commented 2026-05-21 17:09:47 +00:00
Owner
Copy link

From https://todo.gleipnir.technology/tasks/472

Put in an address, and look for one that has “POI” in front of it.

image(3).png

Any of these would work, because it says “poi” in front of the address. Click on one. The red dot goes to the location but the address doesn’t get put in the text box

image(2).png

When you go to submit it, the website says you didn’t provide an address.

image(1).png

From https://todo.gleipnir.technology/tasks/472 Put in an address, and look for one that has “POI” in front of it. ![image(3).png](/attachments/523a212b-c78b-4848-bb55-88d7c9ad0d89) Any of these would work, because it says “poi” in front of the address. Click on one. The red dot goes to the location but the address doesn’t get put in the text box ![image(2).png](/attachments/249a3231-ef55-4391-aae0-29c2567a1f92) When you go to submit it, the website says you didn’t provide an address. ![image(1).png](/attachments/f20fffde-d034-47a5-b9a5-d70989dcd140)
image(1).png
38 KiB
image(2).png
553 KiB
image(3).png
88 KiB
eliribble commented 2026-05-21 17:22:21 +00:00
Author
Owner
Copy link

Looks like the “???” actually comes from our provider, Stadia, so it's not our own placeholder. Stadia actually sets that as the locality.

Looks like the “???” actually comes from our provider, Stadia, so it's not our own placeholder. Stadia actually sets that as the locality.
eliribble commented 2026-05-21 17:24:39 +00:00
Author
Owner
Copy link

The actual problem is that the response from our geocoding endpoint is:

{"address":{"country":"","gid":"openstreetmap:venue:way/112659018","locality":"","location":{"accuracy":null,"latitude":22.315397,"longitude":114.045221},"number":"","postal_code":"","raw":"","region":"Tsuen Wan","street":"","unit":""},"cell":"8f411cb0c9938d2"}

So, there's not much address there.

The actual problem is that the response from our geocoding endpoint is: ```json {"address":{"country":"","gid":"openstreetmap:venue:way/112659018","locality":"","location":{"accuracy":null,"latitude":22.315397,"longitude":114.045221},"number":"","postal_code":"","raw":"","region":"Tsuen Wan","street":"","unit":""},"cell":"8f411cb0c9938d2"} ``` So, there's not much address there.
eliribble commented 2026-05-21 17:26:25 +00:00
Author
Owner
Copy link

The log for Stadia requests shows:

{
  "bbox": [
    114.0447293,
    22.3152318,
    114.045553,
    22.3155521
  ],
  "type": "FeatureCollection",
  "features": [
    {
      "bbox": [
        114.0447293,
        22.3152318,
        114.045553,
        22.3155521
      ],
      "type": "Feature",
      "geometry": {
        "type": "Point",
        "coordinates": [
          114.045221,
          22.315397
        ]
      },
      "properties": {
        "gid": "openstreetmap:venue:way/112659018",
        "name": "迪士尼 Disneyland Resort",
        "layer": "poi",
        "context": {
          "whosonfirst": {
            "region": {
              "gid": "whosonfirst:region:85671827",
              "name": "Tsuen Wan",
              "abbreviation": "TW"
            },
            "macroregion": {
              "gid": "whosonfirst:macroregion:1159397229",
              "name": "New Territories"
            }
          }
        },
        "sources": [
          {
            "source": "openstreetmap",
            "fixit_url": "https://www.openstreetmap.org/edit?way=112659018",
            "source_id": "way/112659018"
          }
        ],
        "addendum": {
          "osm": {
            "operator": "香港鐵路有限公司 MTR Corporation",
            "wikidata": "Q2114035",
            "wikipedia": "zh:迪士尼站",
            "wheelchair": "yes"
          }
        },
        "precision": "centroid"
      }
    }
  ],
  "geocoding": {
    "query": {
      "ids": "openstreetmap:venue:way/112659018"
    },
    "attribution": "https://stadiamaps.com/attribution/"
  }
}
The log for Stadia requests shows: ``` { "bbox": [ 114.0447293, 22.3152318, 114.045553, 22.3155521 ], "type": "FeatureCollection", "features": [ { "bbox": [ 114.0447293, 22.3152318, 114.045553, 22.3155521 ], "type": "Feature", "geometry": { "type": "Point", "coordinates": [ 114.045221, 22.315397 ] }, "properties": { "gid": "openstreetmap:venue:way/112659018", "name": "迪士尼 Disneyland Resort", "layer": "poi", "context": { "whosonfirst": { "region": { "gid": "whosonfirst:region:85671827", "name": "Tsuen Wan", "abbreviation": "TW" }, "macroregion": { "gid": "whosonfirst:macroregion:1159397229", "name": "New Territories" } } }, "sources": [ { "source": "openstreetmap", "fixit_url": "https://www.openstreetmap.org/edit?way=112659018", "source_id": "way/112659018" } ], "addendum": { "osm": { "operator": "香港鐵路有限公司 MTR Corporation", "wikidata": "Q2114035", "wikipedia": "zh:迪士尼站", "wheelchair": "yes" } }, "precision": "centroid" } } ], "geocoding": { "query": { "ids": "openstreetmap:venue:way/112659018" }, "attribution": "https://stadiamaps.com/attribution/" } } ```
eliribble commented 2026-05-21 17:32:59 +00:00
Author
Owner
Copy link

This means we actually don't have an address from Stadia at the direct API level either. We don't know this at the time we do auto-complete. At that point all we have is {"detail":"迪士尼 Disneyland Resort","gid":"openstreetmap:venue:way/112659018","locality":"???","type":"poi"}

I think given our options, we're doing the best thing we can do here. If they want Disneyland, we at least let them select it because that zooms the map to the location and then they can select an actual location on the map.

What we could do is warn them that while they've selected a auto-complete, it doesn't have an address associated with it. We should be capturing that they selected address with GID openstreetmap:venue:way/112659018", and we do show that in the communication workbench when the report is submitted.

Ben, any thoughts on whether or not we should somehow warn users that they selected a location, but it doesn't have an associated address?

This means we actually don't have an address from Stadia at the direct API level either. We don't know this at the time we do auto-complete. At that point all we have is `{"detail":"迪士尼 Disneyland Resort","gid":"openstreetmap:venue:way/112659018","locality":"???","type":"poi"}` I think given our options, we're doing the best thing we can do here. If they want Disneyland, we at least let them select it because that zooms the map to the location and then they can select an actual location on the map. What we could do is warn them that while they've selected a auto-complete, it doesn't have an address associated with it. We should be capturing that they selected address with GID `openstreetmap:venue:way/112659018"`, and we do show that in the communication workbench when the report is submitted. Ben, any thoughts on whether or not we should somehow warn users that they selected a location, but it doesn't have an associated address?
eliribble self-assigned this 2026-05-21 17:33:02 +00:00
eliribble commented 2026-05-21 17:55:04 +00:00
Author
Owner
Copy link

@benjaminsperry please take a look at #14 (comment)

@benjaminsperry please take a look at https://source.gleipnir.technology/Gleipnir/nidus-sync/issues/14#issuecomment-39
benjaminsperry commented 2026-05-21 18:45:50 +00:00
Owner
Copy link

An address should not be required, there are many places in our district that are not address identified. The address is useful for finding a place from a public report but we could operate from coordinates as well. The only reason to warn them is if it is different from their own expectations, meaning they choose a point and think it is supposed to have an address but it doesn't.

An address should not be required, there are many places in our district that are not address identified. The address is useful for finding a place from a public report but we could operate from coordinates as well. The only reason to warn them is if it is different from their own expectations, meaning they choose a point and think it is supposed to have an address but it doesn't.
eliribble commented 2026-05-24 03:05:20 +00:00
Author
Owner
Copy link

Okay, closing this because it seems the right thing to do is to accept a location that is address-free without warning.

Okay, closing this because it seems the right thing to do is to accept a location that is address-free without warning.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
0.0.14
0.0.13
0.0.12
0.0.11
0.0.10
0.0.9
0.0.8
0.0.7
v0.0.6
v0.0.3
v0.0.2
v0.0.1
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
eliribble
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Gleipnir/nidus-sync#14
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?